Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cordova/apple): re-enable Apple Silicon builds #1664

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

fortuna
Copy link
Collaborator

@fortuna fortuna commented Jul 13, 2023

I was able to get it working with a release build.

This should address #940

@fortuna fortuna requested a review from a team as a code owner July 13, 2023 21:51
@fortuna fortuna changed the title feat(cordova/apple): re-Enable Apple Silicon builds feat(cordova/apple): re-enable Apple Silicon builds Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8 🎉

Comparison is base (4fa0edc) 36% compared to head (19b73c6) 45%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1664    +/-   ##
=======================================
+ Coverage      36%     45%    +8%     
=======================================
  Files          45      39     -6     
  Lines        2748    1943   -805     
  Branches      312     312            
=======================================
- Hits         1006     885   -121     
+ Misses       1742    1058   -684     
Flag Coverage Δ
apple ?
ios ?
unittests 45% <ø> (+8%) ⬆️
www 45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fortuna
Copy link
Collaborator Author

fortuna commented Jul 17, 2023

Thoughts?

@fortuna fortuna merged commit 8c13f4d into master Jul 17, 2023
13 checks passed
@fortuna fortuna deleted the fortuna-silicon branch July 17, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants